Rework process dump cri-containerd tests #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aims to deflake the Windows process dump test by continuously checking for a .dmp instead of waiting some arbitrary amount of time and then checking once. While we haven't seen any flakes with the Linux version of this test for generating coredumps, the same logic is employed for the LCOW test as well. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
|
@ambarve Assigning you as you were the one who found this originally I believe 😆 |
anmaxvl
approved these changes
Jan 7, 2022
Comment on lines
1492
to
1495
| for { | ||
| if done { | ||
| break | ||
| } |
There was a problem hiding this comment.
nit: we could use for !done here instead
There was a problem hiding this comment.
Oh great point, I'll change and check in after
Change from breaking out of for loop when done to a `for !done {}` approach.
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to de-flake the Windows process dump test by continuously checking for a .dmp instead of waiting some arbitrary amount of time and then checking once. While we haven't seen any flakes with the Linux version of this test for generating core dumps, the same logic is employed for the LCOW test as well to keep it consistent.