Add powershell to hostprocess container paths #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
hpc-pshell-path
branch
from
3350b92
to
9f65108
Compare
|
cc @marosset |
marosset
reviewed
Aug 3, 2022
A large use case for these containers is to get a shell onto a node or to carry out administrative tasks via powershell commands, but a lot of images have a PATH defined in the docker file that only includes system32. Before any sort of slim image is available for these that doesn't have a PATH set (so it will just use the hosts) add in powershell and the system32/wbem dir for wmic to alleviate some "what is going on" moments. Additionally rearrange some code closer together that was a bit too spread for no reason. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
hpc-pshell-path
branch
from
9f65108
to
5cfa86d
Compare
marosset
approved these changes
Aug 3, 2022
helsaawy
approved these changes
Aug 3, 2022
ambarve
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large use case for these containers is to get a shell onto a node or
to carry out administrative tasks via powershell commands, but a lot
of images have a PATH defined in the docker file that only includes system32.
Before any sort of slim image is available for these that doesn't have a
PATH set (so it will just use the hosts) add in powershell and the system32/wbem
dir for wmic to alleviate some "what is going on" moments. Additionally
rearrange some code closer together that was a bit too spread for no reason.