Update to Go 1.18 #1479
Merged
Update to Go 1.18 #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.17 is out of support as of 1.19's release and there's no real pressing need to stay on 1.17. 1.18 apparently has a smarter traversal of deps as quite a few entries get plucked out. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
This change pins the CI to a patch release of 1.18. Prior we were using a caret specifier set to ^1.17.0 which matches to >= 1.17.0 but <2.0.0 Additionally move all go-version calls to read from a global environment variable so we only need to edit one spot to change the go version. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Might as well stay up to date, and the version we were using I believe didn't support linting generics Signed-off-by: Daniel Canter <dcanter@microsoft.com>
|
Linter has a bunch of new things to whine about on our old code, namely to get off of ioutil and some gofmt things. We have |
|
Sure, we can fix in a future PR as long as the linter isn't actively complaining. |
anmaxvl
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
Bumps go.mod to 1.18. 1.17 is out of support as of 1.19's release and there's no real pressing
need to stay on 1.17. 1.18 apparently has a smarter traversal of deps as
quite a few entries in go.sum get plucked out.
Pins the CI to a patch release of 1.18. Prior we were
using a caret specifier set to ^1.17.0 which matches to >= 1.17.0 but <2.0.0.
This also moves all
go-versioncalls to read from a global environmentvariable so we only need to edit one spot to change the go version in our CI.
Updates golangci-lint to 1.48.0 and the v3 version of the action.