Fix seeding for generative policy tests #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeding the `testRand` module level variable. However, testing/quick was not set to use that seeded random number generator. The testing/quick configuration has a field `Rand` which is not set, will result in a random number generator being created and used. This created generator hasn't been seeded so our seeding had no impact on any of our `Generate` functions. This commit updates all testing/quick tests to initialize `Rand` in the configuration to be set to our seeded `testRand`. Signed-off-by: Sean T. Allen <seanallen@microsoft.com>
helsaawy
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeding the
testRandmodule level variable. However, testing/quick was not set to use that seeded random number generator. The testing/quick configuration has a fieldRandwhich is not set, will result in a random number generator being created and used. This created generator hasn't been seeded so our seeding had no impact on any of ourGeneratefunctions.This commit updates all testing/quick tests to initialize
Randin the configuration to be set to our seededtestRand.Signed-off-by: Sean T. Allen seanallen@microsoft.com