Add policy enforcement for overlay unmounting #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
approved these changes
Oct 7, 2022
We previously weren't doing any enforcement around whether an overlay should be allowed to be unmounted. The initial logic is very simple and matches our device unmounting logic: only allow an unmount if we've seen a mount. When we get to the hardening PRs, we'll want to revisit this basic rule and decide if we want to make it more vigorous in policy or if we want to put all hardening in GCS or some mixture in-between. That's a design discussion we'll need to have. Signed-off-by: Sean T. Allen <seanallen@microsoft.com> Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
We previously weren't doing any enforcement around whether an overlay should be allowed to be unmounted. The initial logic is very simple and matches our device unmounting logic: only allow an unmount if we've seen a mount. When we get to the hardening PRs, we'll want to revisit this basic rule and decide if we want to make it more vigorous in policy or if we want to put all hardening in GCS or some mixture in-between. That's a design discussion we'll need to have. Signed-off-by: Sean T. Allen <seanallen@microsoft.com> Signed-off-by: Matthew A Johnson <matjoh@microsoft.com> Co-authored-by: Sean T. Allen <seanallen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously weren't doing any enforcement around whether an overlay should be allowed to be unmounted. The initial logic is very simple and matches our device unmounting logic:
only allow an unmount if we've seen a mount.
When we get to the hardening PRs, we'll want to revisit this basic rule and decide if we want to make it more vigorous in policy or if we want to put all hardening in GCS or some mixture in-between. That's a design discussion we'll need to have.