Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DumpStacks policy enforcement point. #1543

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Adding DumpStacks policy enforcement point. #1543

merged 1 commit into from
Oct 13, 2022

Conversation

matajoh
Copy link
Member

@matajoh matajoh commented Oct 12, 2022

DumpStacks allows access to guest stacks. Can be used for debugging etc. This gates it with a simple yes/no for policy.

@matajoh matajoh requested a review from a team as a code owner October 12, 2022 08:16
@matajoh
Copy link
Member Author

matajoh commented Oct 12, 2022

@anmaxvl @helsaawy

@SeanTAllen @matajoh
Adding DumpStacks policy enforcement point.
f95c4c5 
DumpStacks allows access to guest stacks. Can be used for debugging etc.
This gates it with a simple yes/no for policy.

Signed-off-by: Sean T. Allen <seanallen@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
anmaxvl
anmaxvl approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. few nits to address later.

pkg/securitypolicy/regopolicy_test.go Show resolved Hide resolved
test/cri-containerd/policy_test.go Show resolved Hide resolved
@anmaxvl anmaxvl merged commit 875a40e into microsoft:main Oct 13, 2022
@anmaxvl anmaxvl deleted the dump-stacks-policy-2 branch October 13, 2022 21:51
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@matajoh @SeanTAllen
Adding DumpStacks policy enforcement point. (microsoft#1543)
0ce7616 
DumpStacks allows access to guest stacks. Can be used for debugging etc.
This gates it with a simple yes/no for policy.

Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Co-authored-by: Sean T. Allen <seanallen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helsaawy helsaawy helsaawy approved these changes

@anmaxvl anmaxvl anmaxvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matajoh @anmaxvl @helsaawy @SeanTAllen