Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/tools/securitypolicy: switch to github.com/pelletier/go-toml #1620

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

thaJeztah
Copy link
Contributor

The BurntSushi/toml module was unmaintained for a long time, and most projects switched over to using pelletier/go-toml. While it appears that maintenance was handed over to a new maintainer (BurntSushi/toml#273), switching to the most commonly used implementation to simplify dependency management.

@thaJeztah thaJeztah requested a review from a team as a code owner January 14, 2023 23:42
The BurntSushi/toml module was unmaintained for a long time, and most
projects switched over to using pelletier/go-toml. While it appears
that maintenance was handed over to a new maintainer, switching to
the most commonly used implementation to simplify dependency management.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@anmaxvl, any issues?

@anmaxvl anmaxvl merged commit 9f4ddc6 into microsoft:main Jan 30, 2023
anmaxvl pushed a commit to anmaxvl/hcsshim that referenced this pull request Feb 1, 2023
…microsoft#1620)

The BurntSushi/toml module was unmaintained for a long time, and most
projects switched over to using pelletier/go-toml. While it appears
that maintenance was handed over to a new maintainer, switching to
the most commonly used implementation to simplify dependency management.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
…microsoft#1620)

The BurntSushi/toml module was unmaintained for a long time, and most
projects switched over to using pelletier/go-toml. While it appears
that maintenance was handed over to a new maintainer, switching to
the most commonly used implementation to simplify dependency management.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants