Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: rego exec in uvm cri integration tests #1648

Merged
merged 3 commits into from
Mar 14, 2023
Merged

tests: rego exec in uvm cri integration tests #1648

merged 3 commits into from
Mar 14, 2023

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Feb 8, 2023 •
edited
Loading

Depends on #1635

@anmaxvl anmaxvl mentioned this pull request Feb 8, 2023
Merged
@helsaawy helsaawy self-assigned this Feb 8, 2023
@anmaxvl anmaxvl changed the title Tests/rego exec in uvm cri integration tests: rego exec in uvm cri integration tests Feb 10, 2023
helsaawy
helsaawy reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing shimDiagExecOutput to return an error pollutes the code flow, but aside from that (and needing to change t testing.TB to tb testing.TB), LGTM overall

test/cri-containerd/helper_exec_test.go Outdated Show resolved Hide resolved
@msscotb msscotb self-assigned this Feb 15, 2023
@anmaxvl anmaxvl marked this pull request as ready for review February 16, 2023 16:39
@anmaxvl anmaxvl requested a review from a team as a code owner February 16, 2023 16:39
@anmaxvl anmaxvl force-pushed the tests/rego-exec-in-uvm-cri-integration branch 3 times, most recently from 88d8741 to f1ef504 Compare February 21, 2023 04:53
@anmaxvl anmaxvl force-pushed the tests/rego-exec-in-uvm-cri-integration branch from f1ef504 to 1e3dd23 Compare March 8, 2023 08:59
@anmaxvl anmaxvl closed this Mar 13, 2023
@anmaxvl anmaxvl force-pushed the tests/rego-exec-in-uvm-cri-integration branch from 1e3dd23 to 66fe5f7 Compare March 13, 2023 18:05
@anmaxvl
tests: rego cri-integration tests for exec in UVM
bb31c7a 
Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl
pr feedback: fix unintended parameter change
cf1df8d 
Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl
pr feedback: add another wrapper for shim diag.
6a7c14e 
Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl reopened this Mar 13, 2023
@anmaxvl anmaxvl merged commit 69815bc into microsoft:main Mar 14, 2023
@anmaxvl anmaxvl deleted the tests/rego-exec-in-uvm-cri-integration branch March 14, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helsaawy helsaawy helsaawy left review comments

@msscotb msscotb msscotb approved these changes

Assignees

@msscotb msscotb

@helsaawy helsaawy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmaxvl @msscotb @helsaawy