-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding policy enforcement for User. #1669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments below, but in tandem, does GetUserInfo
actually need to be exposed? Its doesnt do anything for Open
/ClosedDoorSecurityPolicyEnforcer
, and its returns are only ever passed to (SecurityPolicyEnforcer) EnforceCreateContainerPolicy
and (SecurityPolicyEnforcer) EnforceExecInContainerPolicy
, so the userinfo retrieval logic could probably be hidden in those two functions, without needing to change the function signatures
This PR adds policy enforcement for the User property of container processes. Policy authors can now explicitly allow and deny users, groups, and umasks associated with the init process and exec processes that they define on containers. Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
So @helsaawy the current design change was made to avoid the cost of checking the password and group files when the data is not needed, i.e. with Standard and OpenDoor policies. However, if as you say we collapse the functionality into the different methods ( |
lgtm |
This PR adds policy enforcement for the User property of container processes. Policy authors can now explicitly allow and deny users, groups, and umasks associated with the init process and exec processes that they define on containers. Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
This PR adds policy enforcement for the User property of container processes. Policy authors can now explicitly allow and deny users, groups, and umasks associated with the init process and exec processes that they define on containers.