Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for checking the global version for modify policy version support. #2139

Merged

Conversation

princepereira
Copy link
Contributor

@princepereira princepereira commented May 10, 2024

This to check the if the current version of hns supports modify loadbalancer. These functions will be used by Kube proxy to decide whether to go with modify loadbalancer api or not.

@princepereira princepereira requested a review from a team as a code owner May 10, 2024 03:14
hcn/hcnerrors.go Outdated Show resolved Hide resolved
hcn/hcnglobals.go Outdated Show resolved Hide resolved
@princepereira princepereira force-pushed the user/ppereira/modifyPolicyVersion branch 2 times, most recently from 8a23046 to 29907e1 Compare May 13, 2024 07:10
@msscotb msscotb assigned anmaxvl and helsaawy and unassigned anmaxvl and helsaawy May 17, 2024
@princepereira princepereira force-pushed the user/ppereira/modifyPolicyVersion branch from 29907e1 to 555a8e1 Compare May 18, 2024 11:05
hcn/hcnpolicy.go Outdated Show resolved Hide resolved
@helsaawy helsaawy self-assigned this May 22, 2024
@msscotb msscotb assigned helsaawy and unassigned helsaawy May 22, 2024
@princepereira princepereira force-pushed the user/ppereira/modifyPolicyVersion branch from 555a8e1 to e609f69 Compare May 27, 2024 05:31
…port.

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
@princepereira princepereira force-pushed the user/ppereira/modifyPolicyVersion branch from e609f69 to 0daa926 Compare May 30, 2024 10:11
@sbangari
Copy link

sbangari commented Jun 4, 2024

/approve

@helsaawy helsaawy merged commit 8beabac into microsoft:main Jun 4, 2024
19 checks passed
kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Jun 6, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
(cherry picked from commit 8beabac)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok pushed a commit that referenced this pull request Jun 7, 2024
…port. (#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
(cherry picked from commit 8beabac)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Jun 13, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
(cherry picked from commit 8beabac)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 14, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 19, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 19, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Jun 19, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
kiashok pushed a commit that referenced this pull request Jun 19, 2024
…port. (#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
kiashok pushed a commit that referenced this pull request Jun 19, 2024
…port. (#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
kiashok pushed a commit that referenced this pull request Jun 19, 2024
…port. (#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira added a commit to princepereira/hcsshim that referenced this pull request Aug 28, 2024
…port. (microsoft#2139)

Signed-off-by: Prince Pereira <ppereira@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants