fix: use block device mount to format scratch #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default create LCOW will set the number of SCSI controllers to 4, when VPMem isn't used, which is the case when formatting scratch. This makes the device path lookup non-determenistic, since the SCSI controllers in the guest may have different indices. To workaround that, use a block device mount and use the mount-path to format the scratch VHDX without needing to lookup the actual dev node path. Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
fix/runhcs-scratch-formatting
branch
from
80ce665
to
716c45a
Compare
kiashok
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, create LCOW will set the number of SCSI controllers to 4,
when VPMem isn't used, which is the case when formatting scratch.
This makes the device path lookup non-determenistic, since the
SCSI controllers in the guest may have different indices.
To workaround that, use a block device mount and
use the mount-path to format the scratch VHDX
without needing to lookup the actual dev node path.