Update mksyscall_windows.go to match upstream updates #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jhowardmsft @jstarks |
jstarks
requested changes
Nov 19, 2016
| func (_ *Fn) IsUTF16() bool { | ||
| return true | ||
| func (f *Fn) IsUTF16() bool { | ||
| s := f.DLLFuncName() |
There was a problem hiding this comment.
This reverts a change I made. All our functions use UTF-16.
There was a problem hiding this comment.
Oops, was juggling too many copies of this file (there's gotta be a better vendoring solution than is currently being used). Fixed.
Signed-off-by: Darren Stahl <darst@microsoft.com>
darstahl
force-pushed
the
UpdateMkSyscall
branch
from
3ce496d
to
e9f85e3
Compare
jstarks
approved these changes
Nov 19, 2016
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
Updated user mode preparation instructions in response to the removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream mksyscall_windows.go has had many updates since this was forked. This updates to match.
Signed-off-by: Darren Stahl darst@microsoft.com