Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Lasso, Ridge and ElasticNet #625

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Adds Lasso, Ridge and ElasticNet #625

merged 3 commits into from
Aug 29, 2022

Conversation

fd0r
Copy link
Contributor

@fd0r fd0r commented Aug 22, 2022

closes #624

fd0r and others added 2 commits August 22, 2022 18:51
@fd0r
Add ElasticNet, Lasso and Ridge support
bef1488 
Using the same function as for LinearRegression this adds support for
ElasticNet, Lasso and Ridge.

closes microsoft#624
@fd0r
Merge branch 'microsoft:main' into main
21027f6
@ghost
Copy link

ghost commented Aug 22, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@codecov-commenter
Copy link

Codecov Report

Merging #625 (21027f6) into main (8df9db3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   90.17%   90.18%           
=======================================
  Files          78       78           
  Lines        4549     4552    +3     
  Branches      943      943           
=======================================
+ Hits         4102     4105    +3     
  Misses        252      252           
  Partials      195      195
Flag Coverage Δ
unittests 90.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmingbird/ml/operator_converters/sklearn/linear.py 100.00% <100.00%> (ø)
hummingbird/ml/supported.py 92.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ksaur ksaur requested a review from interesaaat August 22, 2022 17:45
@ksaur
Copy link
Contributor

ksaur commented Aug 23, 2022

Thanks so much for this contribution! Thanks for adding tests!
@interesaaat can take a look when he is back shortly :)

interesaaat
interesaaat approved these changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@interesaaat interesaaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@interesaaat
Copy link
Collaborator

interesaaat commented Aug 29, 2022 •
edited
Loading

Can you please merge with master? (I would do it but I am currently OOF)

@ksaur ksaur merged commit 0a1f21e into microsoft:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@interesaaat interesaaat interesaaat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Lasso, Ridge and ElasticNet
4 participants
@fd0r @codecov-commenter @ksaur @interesaaat