Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-storybook theming and base card create #16

Merged
merged 9 commits into from
Feb 27, 2021
Merged

Non-storybook theming and base card create #16

merged 9 commits into from
Feb 27, 2021

Conversation

ccrowley96
Copy link
Contributor

Closing #14
Closing #15

@ccrowley96 ccrowley96 added the enhancement 💡 New feature or request label Feb 26, 2021
darsney
darsney approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@darsney darsney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe think about makin the preview pop a little more with 2 more colors and a lil padding per my comment

jl-g
jl-g reviewed Feb 26, 2021
View reviewed changes
src/Cards/Base/Consume/BaseCard.tsx Outdated Show resolved Hide resolved
src/Cards/Base/Create/BaseCardCreate.test.tsx Show resolved Hide resolved
src/Cards/Linechart/Consume/LinechartCard.stories.tsx Show resolved Hide resolved
tools/templates/create/component.js Outdated Show resolved Hide resolved
@ccrowley96 ccrowley96 merged commit 0abd00b into main Feb 27, 2021
@ccrowley96 ccrowley96 deleted the user/cocrowle/non-storybook branch February 27, 2021 00:33
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ccrowley96 ccrowley96 linked an issue Mar 1, 2021 that may be closed by this pull request
Base card create (basic) (Cory) #14
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niusoff niusoff niusoff left review comments

@jl-g jl-g jl-g left review comments

@iremgokce iremgokce iremgokce left review comments

@darsney darsney darsney approved these changes

Assignees
No one assigned
Labels
enhancement 💡 New feature or request released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base card create (basic) (Cory)
5 participants
@ccrowley96 @darsney @niusoff @jl-g @iremgokce