This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Fix setup bugs encountered when provisioning in Vagrant #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct directory to add to PYTHONPATH is <z3 build dir>/python. Previously was just <z3 build dir> in z3.sh.
The `ivy` executable ends up importing ivy_graphviz, which requires pydot to be installed.
mister-walter
changed the title
|
|
|
Changes merged -- thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs that I encountered when provisioning a new Ivy Vagrant machine earlier today:
The
scripts/setup/z3.shscript appended the incorrect Z3 directory toPYTHONPATH; it should have been<z3 build dir>/pythonbut was just<z3 build dir>Running the
ivyexecutable ends up importing some UI stuff, which requires thepydotPython library. I added a linescripts/setup/python.shthat installs thepydotpackage from PIP.