Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds response headers to API exception #81

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Adds response headers to API exception #81

merged 3 commits into from
Apr 27, 2023

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Apr 26, 2023 •
edited
Loading

baywet
baywet previously approved these changes Apr 26, 2023
View reviewed changes
@andrueastman andrueastman marked this pull request as ready for review April 27, 2023 06:06
baywet
baywet previously approved these changes Apr 27, 2023
View reviewed changes
@baywet
Copy link
Member

baywet commented Apr 27, 2023

@andrueastman this is conflicting, do you mind taking a look please?

@andrueastman
Copy link
Member Author

Thanks @baywet

Resolved in latest update. as #82 was merged before.

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman changed the title Adds response headers Adds response headers to API exception Apr 27, 2023
@andrueastman andrueastman self-assigned this Apr 27, 2023
@andrueastman andrueastman merged commit 5904f6a into main Apr 27, 2023
@andrueastman andrueastman deleted the addResponseHeaders branch April 27, 2023 12:21
This was referenced Apr 27, 2023
Closed
Closed
Open
Open
Closed
@NerdJeremia NerdJeremia mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@peombwa peombwa Awaiting requested review from peombwa

@calebkiage calebkiage Awaiting requested review from calebkiage

@rkodev rkodev Awaiting requested review from rkodev

Assignees

@andrueastman andrueastman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet