Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile with /permissive- #42

Closed
jrave opened this issue Apr 6, 2018 · 2 comments
Closed

Does not compile with /permissive- #42

jrave opened this issue Apr 6, 2018 · 2 comments

Comments

@jrave
Copy link
Contributor

jrave commented Apr 6, 2018

Latest versions of VS2017 have /permissive- as the default setting but unfortunately krabsetw does not compile with it enabled:

1>c:\users\<foobar>\documents\visual studio 2017\projects\krabstesting\packages\krabsetw.1.0.11\lib\native\include\krabs\filtering\comparers.hpp(100): error C2760: syntax error: unexpected token '}', expected ';'

1>c:\users\<foobar>\documents\visual studio 2017\projects\krabstesting\packages\krabsetw.1.0.11\lib\native\include\krabs\filtering\comparers.hpp(101): note: see reference to class template instantiation 'krabs::predicates::comparers::iequal_to<T>' being compiled

Used versions:
krabsetw: 1.0.11 nuget package
VS 2017 15.6.5

@zacbrown
Copy link
Collaborator

zacbrown commented Apr 7, 2018

Hi,

Thanks for the bug! While I can fix this relatively easy issue, it looks like the Windows SDK combaseapi.h header isn't /permissive- compliant either with the Windows 8.1 SDK:

1>c:\program files (x86)\windows kits\8.1\include\um\combaseapi.h(229): error C2760: syntax error: unexpected token 'identifier', expected 'type specifier'

Unfortunately, moving to the Windows 10 SDK appears non-trivial generating a large number of errors. We'd happily accept a patch for this issue if you have the time and inclination to work on it.

Otherwise, this will be either pulled off the backlog when either an OSS contributor (mainly me) or an MSFT employee has time to fix the issue. I can't speak to when MSFT might come around to this fix.

@jrave
Copy link
Contributor Author

jrave commented Apr 7, 2018

Not entirely sure where you saw the large number of errors when switching to latest Windows 10 SDK. So had a quick look and made a PR at #43 . That one at least builds the examples and native tests cleanly.

jrave added a commit to jrave/krabsetw that referenced this issue Apr 8, 2018
zacbrown pushed a commit that referenced this issue Apr 12, 2018
* Fix errors when building with /permissive- (#42)

* Update solution and projects to VS 2017 (#42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants