Add time_out parameter for wait_operation. #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiliDeng
force-pushed
the
lildeng/fix_issues_1_6
branch
2 times, most recently
from
bd74cb9
to
a6c788d
Compare
squirrelsc
reviewed
Jan 6, 2022
| operation.wait(1) | ||
| if time_out < timer.elapsed(): | ||
| raise Exception("Timeout on operation") | ||
| else: |
There was a problem hiding this comment.
even it's not set, it's still needed to wait by one second. It makes the check_cancelled run more frequently.
squirrelsc
reviewed
Jan 6, 2022
| break | ||
| operation.wait(1) | ||
| if time_out < timer.elapsed(): | ||
| raise Exception("Timeout on operation") |
There was a problem hiding this comment.
"timeout on wait Azure operation completed after {time_out} seconds."
LiliDeng
force-pushed
the
lildeng/fix_issues_1_6
branch
from
a6c788d
to
eb9648d
Compare
LiliDeng
force-pushed
the
lildeng/fix_issues_1_6
branch
from
eb9648d
to
457a632
Compare
squirrelsc
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.