Migrate Intel MPI InfiniBand Test #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalca
force-pushed
the
kameroncarr/ib-intel
branch
from
3cb21d8
to
de53483
Compare
squirrelsc
reviewed
Mar 2, 2022
squirrelsc
reviewed
Mar 2, 2022
|
It looks good to me. The change of tuple to dataclass can happen before adding new test cases. That doesn't matter, but sounds better order. :) |
squirrelsc
previously approved these changes
Mar 3, 2022
Client IB device name may not match server IB device name Use dataclass instead of tuple to return IB devices
Migrate INFINIBAND-INTEL-MPI-2VM from LISAv2.
kamalca
force-pushed
the
kameroncarr/ib-intel
branch
from
8729f68
to
a5cbda5
Compare
|
I reorganized the commits, but no other changes were made in the past push. |
squirrelsc
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating INFINIBAND-INTEL-MPI-2VM from LISAv2.