QEMU orchestrator: Add support for data disks. #1775
Conversation
| @@ -478,6 +478,10 @@ def _generate_min_capability(self, capability: Any) -> Any: | |||
| min_value.data_disk_count = search_space.generate_min_capability_countspace( | |||
| self.data_disk_count, capability.data_disk_count | |||
| ) | |||
| if self.data_disk_size or capability.data_disk_size: | |||
There was a problem hiding this comment.
@LiliDeng please check if this change will impact Azure data disk tests or not.
cwize1
force-pushed
the
user/chrisgun/datadisk
branch
from
612f58d
to
15206ff
Compare
| nodes_requirement.append(node_capabilities) | ||
| # Check that the general node capabilities are compatible with this node's | ||
| # specific requirements. | ||
| if not node_space.check(nodes_capabilities): |
There was a problem hiding this comment.
I think I finally figured out how node capabilities/requirements are supposed to be handled. Does this look correct?
There was a problem hiding this comment.
Yes, it's right. And the capability is extendable, if there are special things in qemu to enforce like vm_size in Azure.
| # Configure data disks. | ||
| if node_space.disk: | ||
| assert isinstance( | ||
| node_space.disk.data_disk_count, int |
There was a problem hiding this comment.
I originally tried to use node.capability here. But the data_disk_count was an IntRange instead of an int. Is this expected behavior?
There was a problem hiding this comment.
The capability should be set by platform. Its default value is unlimited capacity from 0 to max.
The capability type can be rewritten by platform, like AzureDiskOptionSettings. But it needs to replace the default one by platform like _convert_to_azure_node_space. It's pretty complicated, and undocumented. Feel free to let me know, if there are more questions.
I'm planning to write some resource planner, it may be helpful for lab resource management. But don't rely on it, I don't have time allocated...
No description provided.