Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linux CVT test suite to validate ASR driver functionality #2874

Merged
merged 30 commits into from
Sep 5, 2023
Merged

Add Linux CVT test suite to validate ASR driver functionality #2874

merged 30 commits into from
Sep 5, 2023

Conversation

mohshei786
Copy link
Contributor

  1. Add two data disk(1G, 10G) to system.
  2. Install ASR common extension to get the distro details.
  3. Install ASR distro extension(To load the latest ASR driver)
  4. Download cvt binary and run integrity test.
  5. Copy logs from test node.

squirrelsc
squirrelsc reviewed Aug 24, 2023
View reviewed changes
microsoft/testsuites/vm_extensions/cvt.py
cvt_script=self._cvt_script,
)
log.info(f"ASR CVT test completed with exit code '{result}'")
assert_that(result).described_as("ASR CVT test failed").is_equal_to(0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the output of script is printed together, it's easier to troubleshoot in future. The failure message can be provided by dashboard, so it doesn't need to look into log files. But make it shorter than 200 chars.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohshei786 It looks like the error message is not improved. Any detailed error can be printed with this? @LiliDeng

@LiliDeng LiliDeng merged commit c5c3b49 into microsoft:main Sep 5, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squirrelsc squirrelsc squirrelsc left review comments

@LiliDeng LiliDeng LiliDeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohshei786 @LiliDeng @squirrelsc