dom0_kernel_installer: fix make install failure
#2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /sbin/installkernel script in Mariner expects /boot/mariner.cfg to be present. However, in dom0 (which uses its own derivative of Mariner) this file doesn't exist because it is not needed by dom0 boot. Due to the missing /boot/mariner.cfg, the installkernel script fails and in turn, the `make install` command fails while installing a new kernel. To make the installkernel script happy, create an empty mariner.cfg file. This has no functional impact on dom0 boot configuration since it doesn't use that file at all. Signed-off-by: Anirudh Rayabharam <anrayabh@linux.microsoft.com>
LiliDeng
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /sbin/installkernel script in Mariner expects /boot/mariner.cfg to be present. However, in dom0 (which uses its own derivative of Mariner) this file doesn't exist because it is not needed by dom0 boot.
Due to the missing /boot/mariner.cfg, the installkernel script fails and in turn, the
make installcommand fails while installing a new kernel.To make the installkernel script happy, create an empty mariner.cfg file. This has no functional impact on dom0 boot configuration since it doesn't use that file at all.