Distro Classification for selective billing feature #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arisettisanjana
requested review from
squirrelsc and
LiliDeng
as code owners
arisettisanjana
changed the title
iamashwani-who
approved these changes
Nov 21, 2023
squirrelsc
reviewed
Nov 21, 2023
LiliDeng
reviewed
Nov 22, 2023
arisettisanjana
force-pushed
the
sarisetti/additional_validation
branch
from
02295b4
to
f79a4e8
Compare
LiliDeng
reviewed
Nov 23, 2023
LiliDeng
reviewed
Nov 23, 2023
LiliDeng
reviewed
Nov 23, 2023
LiliDeng
reviewed
Nov 23, 2023
LiliDeng
reviewed
Nov 23, 2023
squirrelsc
reviewed
Nov 24, 2023
squirrelsc
reviewed
Nov 24, 2023
squirrelsc
reviewed
Nov 24, 2023
squirrelsc
reviewed
Nov 24, 2023
LiliDeng
reviewed
Nov 24, 2023
|
See below failure against redhat rhel 9_1 9.1.2022112113, redhat rhel 84-gen2 8.4.2021081004 |
squirrelsc
reviewed
Dec 8, 2023
squirrelsc
reviewed
Dec 8, 2023
LiliDeng
reviewed
Dec 21, 2023
LiliDeng
reviewed
Dec 21, 2023
LiliDeng
reviewed
Dec 21, 2023
LiliDeng
reviewed
Dec 28, 2023
LiliDeng
reviewed
Dec 28, 2023
LiliDeng
approved these changes
Dec 29, 2023
|
@squirrelsc please take a look before merging. |
|
@LiliDeng LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an additional test in LISA to run a script and validate the result.
The script takes the responsibility of distinguishing the various ditros into supported or unsupported for selective billing feature.
The test would be passed in both the cases, just that the information helps in clearly classifying the distro, when the test runs on various distros.
Changes:
Added the script file handle.txt
Modified the vmsnapshot_extension.py to add the test