HyperV tool improvements #3125
Merged
HyperV tool improvements #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While at it, properly escape all arguments to New-VM by surrounding them with double quotes. Signed-off-by: Anirudh Rayabharam <anrayabh@microsoft.com>
Introduce support for configuring COM ports using Set-VMComPort. This is useful for obtaining serial console output from the virtual machine. This functionality will be utilized in the Hyper-V platform. Signed-off-by: Anirudh Rayabharam <anrayabh@microsoft.com>
squirrelsc
reviewed
Jan 3, 2024
Configure COM ports only when com_ports is not None. Signed-off-by: Anirudh Rayabharam <anrayabh@microsoft.com>
|
@LiliDeng LGTM |
LiliDeng
approved these changes
Jan 5, 2024
LiliDeng
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New-VMin double quotes. These arguments can potentially contain spaces and other special chars.All these will be used in the upcoming Hyper-V platform.