Add test to check and log mdatp install/config info #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgov
force-pushed
the
mcgov/defender
branch
4 times, most recently
from
6c8c691
to
205a802
Compare
squirrelsc
reviewed
Mar 26, 2024
squirrelsc
reviewed
Mar 26, 2024
mcgov
changed the title
okopel
suggested changes
Mar 26, 2024
mcgov
force-pushed
the
mcgov/defender
branch
3 times, most recently
from
c248a4d
to
e65341f
Compare
squirrelsc
reviewed
Mar 30, 2024
mcgov
force-pushed
the
mcgov/defender
branch
7 times, most recently
from
bd441b0
to
0ea46fc
Compare
squirrelsc
reviewed
Apr 3, 2024
|
@LiliDeng LGTM |
okopel
reviewed
Apr 4, 2024
okopel
reviewed
Apr 4, 2024
mcgov
force-pushed
the
mcgov/defender
branch
3 times, most recently
from
cc2fd92
to
1394942
Compare
srkoripe
approved these changes
Apr 5, 2024
Already reviewed! Thanks so much. @LiliDeng can we merge this ASAP? |
squirrelsc
reviewed
Apr 10, 2024
LiliDeng
reviewed
Apr 11, 2024
LiliDeng
reviewed
Apr 11, 2024
mcgov
commented
Apr 11, 2024
- stop lisa from overwriting lf to crlf in bash files - mdatp script to check for json files, ascii or utf8 text script fails on detection of any logs or installation, uses exit code as issue signal instead of string parsing
- Add more comments describing the code paths - Add explanation of SKIP if an unexpected error code is found. this implies we're not running in a unix shell, which should not occur, but anything is possible. If that occurs, skip instead of fail or pass.
squirrelsc
reviewed
Apr 11, 2024
-Move to using an int as return code to avoid conflicting with existing shell exit codes. This is done to help differentiate between os/shell errors and a successful validation (either fail or pass)
…ted' code path to a failure with prompt to open a bug
|
@LiliDeng Current version LGTM. |
LiliDeng
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an mdatp test to check configuration info in a VM if defender is installed.