mdatp: Add noexec workaround #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LISA has a bug where it won't consider mount permissions before placing the working path. This example workaround demonstrates a possible fix.
mcgov
force-pushed
the
mcgov/mount-bug-demo-fix
branch
from
d704fca
to
22c0673
Compare
mcgov
force-pushed
the
mcgov/mount-bug-demo-fix
branch
2 times, most recently
from
2fde734
to
a917a3f
Compare
mcgov
force-pushed
the
mcgov/mount-bug-demo-fix
branch
from
a917a3f
to
553237a
Compare
squirrelsc
reviewed
Apr 25, 2024
squirrelsc
reviewed
Apr 25, 2024
squirrelsc
reviewed
Apr 25, 2024
squirrelsc
reviewed
Apr 25, 2024
squirrelsc
reviewed
Apr 25, 2024
squirrelsc
reviewed
Apr 25, 2024
Updating the warning messages to specify that this condition is not fatal *for the mdatp test*. If this code is hoisted outside of the test, it should be fatal. It indicates that our Mount and DF tools are broken and we cannot validate the mount options on partitions.
- Address more code comments - add comments to warn and success paths - re-order if/elseif to put positive case first - rename functions for clarity
squirrelsc
reviewed
Apr 25, 2024
squirrelsc
reviewed
Apr 25, 2024
squirrelsc
reviewed
Apr 25, 2024
mcgov
force-pushed
the
mcgov/mount-bug-demo-fix
branch
from
871abe1
to
826d76e
Compare
squirrelsc
reviewed
May 2, 2024
…ferences in remount commant
mcgov
force-pushed
the
mcgov/mount-bug-demo-fix
branch
from
826d76e
to
2babe3d
Compare
|
@LiliDeng LGTM |
LiliDeng
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LISA
has a bug where it(edited) won't consider mount permissions before placing the working path. This means you'll end with a path where you can maybe read and write but not execute anything regardless of the file permissions.This example workaround demonstrates how to detect the issue and a possible workaround, remounting the partition with the executable permission.