fix failing tests on emotion dataset #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/update-ds-emotion
branch
from
0a33911
to
23bd3b4
Compare
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 70.43% 70.43%
=======================================
Files 24 24
Lines 1326 1326
=======================================
Hits 934 934
Misses 392 392
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaugup
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a known issue with emotion dataset on huggingface failing to download, see:
dair-ai/emotion_dataset#5
The dataset is hosted externally,
Using an alternative link to the dataset on huggingface which is hosted internally.
Update: Also remove normalize parameter as it has been removed on latest scikit-learn pypi package's LinearRegression class to unblock failing builds.