Implement autotools build for TPM and Platform code #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Finally got the CLA stuff sorted out with my employer. This needs to be rebased since I got at least one PR from folks using my fork to do Linux stuff (a good sign). |
Expecting users to change code in order to build for 64bit environments isn't very user friendly. In the case of the RADIX_BITS we can make this easier on users (and automated builds) by using the compiler environment to do the detection for us. Currently the implementation is limited to the __x86_64__ / __i386__ and _WIN64 / _WIN32 macros from linux / windows compilers respectively. An alternative implementation may have used the OpenSSL bn_ops values to determine 32 vs 64bit. This ends up being awkward since Implementation.h is included by other modules and they then end up depending on the openssl headers. Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
This commit adds configuration files implementing a minimal GNU Autotools build. It follows the common `./bootstrap && ./configure && make` convention. Currently it only builds a static library for the code under TPMCmd/tpm/. bootstrap: - runs AUTORECONF configured to create symlinks to the required scripts - generates src.mk file holding variables listing the pathes to source files (relative to srcdir) used in the build - uncomment the required macros in the VendorString header leaving the default values in place configure.ac: - sets up basic project metadata using mostly placeholders, including the version number - does the typical setup for a c program - configures libtool - ensures we're using a compatible version of openssl - sets up recommended compiler flags being relatively strict - build to 'gnu11', this is c11 with a bunch of POSIX and GNU features enabled - treat all warnings as errors - explicitly ignore warnings caused by the current code Makefile.am: - build a static library for the 'tpm' module .gitignore: update to ignore build output on linux Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
If travis-ci has been configured to monitor this git repo then it will parse the .travis.yml file and build accordingly. This configuration file will cause travis-ci to: - configure the builder to build C code - execute the build on the Ubuntu Trusty container (64bit) - install dependencies - enable cross compiling to i386 / 32bit - install multilib toolcain - configure pacakge manager to install i386 packages - install libssl-dev for i386 - setup the build matrix (4 builds total) - build for using gcc and clang compilers - create environments for building 64bit and 32bit builds - bootstrap, configure and build the code Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
This requires that we: - add code to the bootstrap script to generate variables holding the paths to source code and headers: PLATFORM_C and PLATFORM_H - add rules to Makefile.am to build this code in PLATFORM_C into libplatform.a - add libplatform.a to .gitignore - ignore warnings about unused results. GCC on travis-ci complains about NVMem.c in Platform ignoring results from `fread`. Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>
|
Rebase onto master and an upgrade to the travis-ci build image are working. An example of the travis-ci build is here: https://travis-ci.org/flihp/ms-tpm-20-ref/builds/465836354. I don't know how Microsoft manages their CI stuff but if you can enable travis-ci for this repo the |
|
I've checked that the build works on Ubuntu 17.04. One needs to make sure that the following packages are installed before running the build scripts: autoconf-archive, pkg-config, libssl-dev. Awesome work, Philip! Thanks a lot! |
This was referenced Dec 14, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimum required to:
TPMCmd/tpmas a static library called libtpm.aTPMCmd/Platformas a static library called libplatform.aThe only code changes required to do this are a minor change to a preprocessor macro to accommodate GCC and clang and the generation of the RADIX_BITS value from the compiler environment. The rest of this is just the addition of build script and config for the autotools.