Stream Shutdown on Failure in Operation Cleanup (#2591) #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While inspecting the code I noticed that we only were apply the logic for
QUIC_STREAM_START_FLAG_SHUTDOWN_ON_FAILin the failure path ofQuicStreamStart, and not in the operation clean up path ofQuicOperationQueueClearwhich happens when a connection is cleaned up.Testing
As this is a nearly impossible timing window to hit with a test, I will rely on spinquic and existing tests to hopefully exercise.
Documentation
None. This is just fixing a bug.