Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EADDRNOTAVAIL code is 49 on macos #3037

Merged
merged 1 commit into from
Sep 1, 2022
Merged

EADDRNOTAVAIL code is 49 on macos #3037

merged 1 commit into from
Sep 1, 2022

Conversation

pedrobsaila
Copy link
Contributor

@pedrobsaila pedrobsaila commented Sep 1, 2022 •
edited
Loading

Description

Follow up PR for dotnet/runtime#74053. As mentioned by @rzikm, the code error for EADDRNOTAVAIL code is 49 on macos.

dotnet/runtime#74780 (comment)

@pedrobsaila pedrobsaila requested a review from a team as a code owner September 1, 2022 20:22
@nibanks nibanks added external Proposed by non-MSFT Area: API Language: C# Related to the C# interop layer labels Sep 1, 2022
@nibanks nibanks enabled auto-merge (squash) September 1, 2022 20:25
@rzikm
Copy link
Member

rzikm commented Sep 1, 2022

I also noticed the #define statements are missing in the msquic_*.h files, should they be added as well?

@nibanks
Copy link
Member

nibanks commented Sep 1, 2022

I also noticed the #define statements are missing in the msquic_*.h files, should they be added as well?

Probably a good idea.

@nibanks nibanks merged commit 7e9b482 into microsoft:main Sep 1, 2022
@pedrobsaila pedrobsaila deleted the 74053-macos branch September 1, 2022 20:41
@pedrobsaila pedrobsaila mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibanks nibanks nibanks approved these changes

Assignees
No one assigned
Labels
Area: API external Proposed by non-MSFT Language: C# Related to the C# interop layer OS: macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedrobsaila @rzikm @nibanks