Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): allow QUIC_CONNECTION_EVENT_PEER_NEEDS_STREAMS #3148

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix(test): allow QUIC_CONNECTION_EVENT_PEER_NEEDS_STREAMS #3148

merged 1 commit into from
Oct 14, 2022

Conversation

qzhuyan
Copy link
Contributor

@qzhuyan qzhuyan commented Oct 13, 2022

Description

To make "test down level" pass in #3118

Testing

I have tested manually on ubuntu 20.04 with the msquic binary built from #3118

Documentation

N/A

nibanks
nibanks approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you been able to validate this?

@nibanks
Copy link
Member

nibanks commented Oct 13, 2022

/azp run ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nibanks nibanks added the Area: Testing Related to test coverage label Oct 13, 2022
@qzhuyan
Copy link
Contributor Author

qzhuyan commented Oct 14, 2022

LGTM. Have you been able to validate this?

I tested on ubuntu 20.04.
I took the artifacts/bin/linux/x64_Debug_openssl/msquic* built from this branch and run the test against the binary file in #3118

with

pwsh ./scripts/test.ps1  -ErrorsAsWarnings

These are the failing tests: (I think they are expected to fail)

CredValidation.ConnectExpiredClientCertificate
CredValidation.ConnectExpiredServerCertificate
CredValidation.ConnectValidClientCertificate
CredValidation.ConnectValidServerCertificate

TlsTest.InProcCertificateValidation
TlsTest.InProcPortableCertificateValidation

@qzhuyan qzhuyan marked this pull request as ready for review October 14, 2022 08:28
@qzhuyan qzhuyan requested a review from a team as a code owner October 14, 2022 08:28
@nibanks nibanks merged commit 3f1a134 into microsoft:release/2.1 Oct 14, 2022
nibanks pushed a commit that referenced this pull request Oct 14, 2022
@qzhuyan @nibanks
fix(test): allow QUIC_CONNECTION_EVENT_PEER_NEEDS_STREAMS (#3148)
33bf778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibanks nibanks nibanks approved these changes

Assignees
No one assigned
Labels
Area: Testing Related to test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qzhuyan @nibanks