Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP: v2.1 Load Balancing Fixed Server ID #3195

Merged
merged 1 commit into from
Nov 3, 2022
Merged

CP: v2.1 Load Balancing Fixed Server ID #3195

merged 1 commit into from
Nov 3, 2022

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Oct 28, 2022

Description

See #3172.

@nibanks nibanks requested a review from a team as a code owner October 28, 2022 13:54
@nibanks nibanks added Area: API Area: Core Related to the shared, core protocol logic labels Oct 28, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 28, 2022
View reviewed changes
src/core/settings.c
if (!Settings->IsSet.FixedServerID &&
!MsQuicLib.InUse) {
ValueLen = sizeof(Settings->FixedServerID);
CxPlatStorageReadValue(

Check warning

Code scanning / CodeQL

Expression has no effect

This expression has no effect (because [CxPlatStorageReadValue](1) has no external side effects).
@nibanks nibanks merged commit be203ca into release/2.1 Nov 3, 2022
@nibanks nibanks deleted the nibanks/cp-lb branch November 3, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csujedihy csujedihy csujedihy approved these changes

Assignees
No one assigned
Labels
Area: API Area: Core Related to the shared, core protocol logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nibanks @csujedihy