Split out CQE completion routines for winuser #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Dec 13, 2022
| CXPLAT_SEND_DATA* SendData = CONTAINING_RECORD(Sqe, CXPLAT_SEND_DATA, Sqe); | ||
| CXPLAT_SOCKET_PROC* SocketProc = SendData->SocketProc; | ||
|
|
||
| #ifdef CXPLAT_DATAPATH_QUEUE_SENDS |
There was a problem hiding this comment.
I forgot to in my PR, but could you remove CXPLAT_DATAPATH_QUEUE_SENDS from CMakeList.txt? That should be the last reference.
There was a problem hiding this comment.
Will do in my next PR - I don't want to restart the tests, and I have other PRs dependent on this one.
nibanks
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
As a follow up for #3282, split the IO completion routines into atomic units.
Testing
Do any existing tests cover this change? Are new tests needed?
CI/CD
Documentation
Is there any documentation impact for this change?
No.