gamecore_console: avoid importing timeGetDevCaps #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is not part of WINAPI_FAMILY_GAMES available to GDK platforms The proper fix is to refactor our link dependencies on Windows platforms. That is however a risker and more involved change, so this PR intends to address the immediate issue rendering msquic unusable on GDK gaming platform. Signed-off-by: Jianye Chen <jianyechen@microsoft.com>
nibanks
approved these changes
Jan 7, 2023
@jianye-chen thanks for the contribution. It would also be great if you could make a PR for what you suggest above too. |
jianye-chen
added a commit
to jianye-chen/msquic
that referenced
this pull request
Jan 9, 2023
)" This reverts commit 59acb51.
jianye-chen
added a commit
to jianye-chen/msquic
that referenced
this pull request
Jan 10, 2023
…es if possible (#2) * Revert "gamecore_console: avoid importing timeGetDevCaps (microsoft#3332)" This reverts commit 59acb51. * gamecore_console: Windows 10 SDK 19041 or later auto-detect windows sdk version available * use OneCoreUap for uwp and OneCore for win32 * do not enforce sdk ver min Signed-off-by: Jianye Chen <jianyechen@microsoft.com>
jianye-chen
added a commit
to jianye-chen/msquic
that referenced
this pull request
Jan 10, 2023
)" This reverts commit 59acb51.
nibanks
pushed a commit
that referenced
this pull request
Jan 24, 2023
it is not part of WINAPI_FAMILY_GAMES available to GDK platforms The proper fix is to refactor our link dependencies on Windows platforms. That is however a risker and more involved change, so this PR intends to address the immediate issue rendering msquic unusable on GDK gaming platform. Signed-off-by: Jianye Chen <jianyechen@microsoft.com> Signed-off-by: Jianye Chen <jianyechen@microsoft.com>
nibanks
added a commit
that referenced
this pull request
Jan 24, 2023
* Use the new onebranch linux docker image (#3315) * Address onebranch pipeline warnings (#3325) * gamecore_console: avoid importing timeGetDevCaps (#3332) it is not part of WINAPI_FAMILY_GAMES available to GDK platforms The proper fix is to refactor our link dependencies on Windows platforms. That is however a risker and more involved change, so this PR intends to address the immediate issue rendering msquic unusable on GDK gaming platform. Signed-off-by: Jianye Chen <jianyechen@microsoft.com> Signed-off-by: Jianye Chen <jianyechen@microsoft.com> * Adds Hashtable Restructuring (#3344) * Adds Hashtable Restructuring * Extra line in contract path * Make compiler happy * A bit of refactor * Remove unnecessary declaration * formatting * Forgot to remove a few #ifdefs * Updated PGO files * Fix a tag * Update src/platform/hashtable.c * Update src/platform/hashtable.c * Update src/platform/hashtable.c * Rename CXPLAT_HASHTABLE_MAX_RESTRUCT_ATTEMPTS to CXPLAT_HASHTABLE_MAX_RESIZE_ATTEMPTS Co-authored-by: Matt Olson <maolson@microsoft.com> * gamecore_console: default to latest Windows SDK (#3343) Signed-off-by: Jianye Chen <jianyechen@microsoft.com> * Update Quic VNE and Version 2 constants. (#3324) * gamecore_console: fix build with 10.0.20348.0 (#6) (#3348) updated min. SDK to 10.0.20348.0 for SetThreadIdealProcessor Signed-off-by: Jianye Chen <jianyechen@microsoft.com> Signed-off-by: Jianye Chen <jianyechen@microsoft.com> * Fix QUIC_SETTINGS param validation tests. (#3331) * Fix credscan warnings (#3359) * build: fix onebranch pipelines (#3360) changed base image to ltsc2019/vse2019 installed additional SDK to the image added pipeline parameter to specify the target branch Signed-off-by: Jianye Chen <jianyechen@microsoft.com> Signed-off-by: Jianye Chen <jianyechen@microsoft.com> * Update patch version * Use Ubuntu 20.04 to Build OpenSSL-Systemcrypto Variant (#3267) * Fix/suppress some new clang/cppcheck warnings (#3064) Signed-off-by: Jianye Chen <jianyechen@microsoft.com> Co-authored-by: Yi Huang <huanyi@microsoft.com> Co-authored-by: Jianye Chen <jianyechen@microsoft.com> Co-authored-by: Matt Olson <maolson@microsoft.com> Co-authored-by: Anthony Rossi <41394064+anrossi@users.noreply.github.com> Co-authored-by: Lars Eggert <lars@eggert.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
timeGetDevCapsis not available inWINAPI_FAMILY_GAMESand importing it ingamecore_consolebuilds will crash the process at runtime due toDLL_NOT_FOUND.See Windows 10 Software Development Kit (Win10SDK) for the API family available to Microsoft GDK gaming platform.
Testing
Existing tests do not cover the issue fixed by this PR.
The issue should be captured by the linker (and cause build failures) instead of automated tests. We should not link against
OneCore.libongamecore_consoleas it provides the exports for the subset of Win32 APIs that are common to all Windows 10 devices.. Umbrella libraries are designed to ensure we restrict [our] code to Win32 APIs that are supported in the core OS. Forgamecore_console, the umbrella library should be xgameplatform.lib.The proper fix is to refactor our link dependencies on Windows platforms. That is however a riskier and more involved change, so this PR intends to address the immediate issue rendering msquic unusable on GDK gaming platform.
Documentation
N/A