Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transport error code for new alpn negotiation #3647

Conversation

liveans
Copy link
Member

@liveans liveans commented May 23, 2023

Description

Currently, while we're narrowing down the ALPN list with ReNegotiation, if we can't negotiate with client on ALPN, we're closing the connection with QUIC_ERROR_INTERNAL_ERROR, but looks like it should be QUIC_ERROR_CRYPTO_NO_APPLICATION_PROTOCOL.

Testing

I've updated the necessary unit test, but this is a breaking change since we're changing close status behavior.

Documentation

No

@ManickaP
Copy link
Member

This should get into whatever msquic version that will be actual when .NET 8 ships. I.e.: backport to 2.2 unless another release from main will be made.

@nibanks
Copy link
Member

nibanks commented May 24, 2023

This should get into whatever msquic version that will be actual when .NET 8 ships. I.e.: backport to 2.2 unless another release from main will be made.

Yes, this must also be backported because this breaks 2.2 down level tests, because of the test code change. Would you mind creating the PR to cherry pick this to release/2.2 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants