Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay Start Worker Threads #3930

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Delay Start Worker Threads #3930

wants to merge 3 commits into from

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Oct 19, 2023

Description

Updates MsQuic worker logic to delay start the actual threads (when it uses threads; i.e. max_throughput) it creates. This is a no-op for kernel mode which can't delay load since it runs at DISPATCH_LEVEL later.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner October 19, 2023 13:29
@nibanks nibanks added the Area: Core Related to the shared, core protocol logic label Oct 19, 2023
@nibanks nibanks changed the title Delay Start QUIC Worker Threads Delay Start Worker Threads Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #3930 (e348353) into main (81858e4) will decrease coverage by 16.75%.
The diff coverage is 38.70%.

@@             Coverage Diff             @@
##             main    #3930       +/-   ##
===========================================
- Coverage   86.62%   69.87%   -16.75%     
===========================================
  Files          56       56               
  Lines       16889    16913       +24     
===========================================
- Hits        14630    11818     -2812     
- Misses       2259     5095     +2836     
Files Coverage Δ
src/core/worker.h 100.00% <ø> (ø)
src/core/worker.c 73.60% <38.70%> (-14.15%) ⬇️

... and 43 files with indirect coverage changes

@nibanks nibanks marked this pull request as draft October 19, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant