Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Delayed ACK Support #3933

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Better Delayed ACK Support #3933

merged 5 commits into from
Oct 23, 2023

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Oct 20, 2023

Description

  • Support disabling delayed ACK.
  • Don't include timer resolution when polling timeout is greater than delayed ACK timeout.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner October 20, 2023 20:11
@nibanks nibanks added Area: Performance Area: API Area: Core Related to the shared, core protocol logic labels Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #3933 (8d3c102) into main (81858e4) will decrease coverage by 0.44%.
Report is 5 commits behind head on main.
The diff coverage is 66.66%.

❗ Current head 8d3c102 differs from pull request most recent head d8fb4b7. Consider uploading reports for the commit d8fb4b7 to get more accurate results

@@            Coverage Diff             @@
##             main    #3933      +/-   ##
==========================================
- Coverage   86.62%   86.18%   -0.44%     
==========================================
  Files          56       56              
  Lines       16889    16897       +8     
==========================================
- Hits        14630    14563      -67     
- Misses       2259     2334      +75     
Files Coverage Δ
src/core/ack_tracker.c 86.07% <ø> (ø)
src/core/send.c 88.88% <100.00%> (+0.18%) ⬆️
src/core/connection.h 98.38% <80.00%> (-0.51%) ⬇️
src/core/connection.c 80.54% <40.00%> (-1.05%) ⬇️

... and 10 files with indirect coverage changes

src/core/ack_tracker.c Outdated Show resolved Hide resolved
@nibanks nibanks merged commit d65bb1a into main Oct 23, 2023
391 of 397 checks passed
@nibanks nibanks deleted the nibanks/better-delayed-ack branch October 23, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Area: Core Related to the shared, core protocol logic Area: Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants