-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Using Streams after Connection Closure #3938
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3938 +/- ##
==========================================
- Coverage 87.17% 87.01% -0.16%
==========================================
Files 56 56
Lines 16958 16957 -1
==========================================
- Hits 14783 14755 -28
- Misses 2175 2202 +27 ☔ View full report in Codecov by Sentry. |
So currently I can't use stream after its connection closure? I thought the api would reliably return some kind of error code. |
Well, once I finish this PR (ETA: this week) then it won't matter, but the problem before was that the connection would be deleted when you close the stream, so any access would be a use-after-free, without adding more state to the stream itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Allows apps to not worry about close order between streams and connections.
Testing
New test added. Also leverages existing tests (which found some other issues).
Documentation
TODO?