Simplify timer operations #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4032 +/- ##
==========================================
+ Coverage 86.17% 86.78% +0.60%
==========================================
Files 56 56
Lines 16953 16929 -24
==========================================
+ Hits 14610 14691 +81
+ Misses 2343 2238 -105 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Dec 29, 2023
nibanks
reviewed
Dec 29, 2023
nibanks
reviewed
Dec 29, 2023
nibanks
reviewed
Dec 29, 2023
nibanks
reviewed
Dec 29, 2023
nibanks
reviewed
Dec 29, 2023
nibanks
reviewed
Dec 29, 2023
nibanks
reviewed
Dec 29, 2023
Co-authored-by: Nick Banks <nibanks@microsoft.com>
Co-authored-by: Nick Banks <nibanks@microsoft.com>
nibanks
reviewed
Dec 30, 2023
|
|
||
| if (Connection->EarliestExpirationTime == UINT64_MAX) { |
There was a problem hiding this comment.
I'm wondering how necessary this check is... It might be simpler just to remove it.
nibanks
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing timer operations rely on a sorted timer entry array, where each entry has a type and expiration time, to maintain the earliest expiration time. However, it's not necessary to maintain a sorted array for this purpose. The earliest expiration time can be calculated on the fly when setting/canceling/expiring timers with the same complexity (it doesn't really matter as we only have a few timer types) and more readable code.
Testing
CI