fix: apply lb settings after lb mode change #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing an issue where the CID prefix lengths (MsQuicLib.CidServerIdLength and MsQuicLib.CidTotalLength) weren't being updated properly when transitioning the lb mode from its default state (disabled) to QUIC_LOAD_BALANCING_SERVER_ID_IP. This resulted in the server source CIDs not being prefixed with the source IP
nibanks
reviewed
Jan 3, 2024
nibanks
added
external
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4036 +/- ##
==========================================
+ Coverage 86.19% 87.02% +0.82%
==========================================
Files 56 56
Lines 16929 16930 +1
==========================================
+ Hits 14592 14733 +141
+ Misses 2337 2197 -140 ☔ View full report in Codecov by Sentry. |
nibanks
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing an issue where the CID prefix
lengths (
MsQuicLib.CidServerIdLengthandMsQuicLib.CidTotalLength) weren't being updated properly when transitioning the lb mode from its default state (disabled) toQUIC_LOAD_BALANCING_SERVER_ID_IP. This resulted in the server source CIDs not being prefixed with the source IPTesting
New unittest:
TEST(SettingsTest, GlobalLoadBalancingServerIDSet)Documentation
NO