Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMR helper improvement #4045

Merged
merged 1 commit into from
Jan 9, 2024
Merged

NMR helper improvement #4045

merged 1 commit into from
Jan 9, 2024

Conversation

csujedihy
Copy link
Contributor

Description

Allows NMR registration helper to fail more elegantly.

Testing

CI

@csujedihy csujedihy requested a review from a team as a code owner January 9, 2024 22:35
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5949785) 86.13% compared to head (9ed8cbc) 85.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4045      +/-   ##
==========================================
- Coverage   86.13%   85.91%   -0.22%     
==========================================
  Files          56       56              
  Lines       16938    16938              
==========================================
- Hits        14589    14552      -37     
- Misses       2349     2386      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit 878886a into main Jan 9, 2024
352 of 354 checks passed
@nibanks nibanks deleted the huanyi/nmr-helper-timeout branch January 9, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants