Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary Unit Conversion #4543

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Remove Unnecessary Unit Conversion #4543

merged 1 commit into from
Sep 10, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Sep 9, 2024

Description

Fixes #4470.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks added the Bug: Core A code bug in the Core MsQuic code label Sep 9, 2024
@nibanks nibanks requested a review from a team as a code owner September 9, 2024 23:11
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.57%. Comparing base (376265a) to head (1095894).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4543      +/-   ##
==========================================
+ Coverage   85.08%   85.57%   +0.48%     
==========================================
  Files          56       56              
  Lines       15537    15537              
==========================================
+ Hits        13220    13296      +76     
+ Misses       2317     2241      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks enabled auto-merge (squash) September 10, 2024 02:58
@nibanks nibanks merged commit 733da8d into main Sep 10, 2024
470 of 471 checks passed
@nibanks nibanks deleted the nibanks-patch-1 branch September 10, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Core A code bug in the Core MsQuic code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QUIC_SEND_PACING_INTERVAL unit default to us, not need MS_TO_US()
2 participants