Tests | Support multi-platform testing with exclusion tags and fix Skipping tests #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1015 +/- ##
============================================
+ Coverage 50.09% 50.36% +0.26%
- Complexity 2878 2900 +22
============================================
Files 120 120
Lines 27989 27989
Branches 4677 4677
============================================
+ Hits 14022 14096 +74
+ Misses 11713 11633 -80
- Partials 2254 2260 +6
Continue to review full report at Codecov.
|
cheenamalhotra
force-pushed
the
skippedTestsGoAway
branch
from
5a0fec0
to
58a53c8
Compare
peterbae
previously approved these changes
Apr 5, 2019
lilgreenbird
reviewed
Apr 5, 2019
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecuteWithErrorsTest.java
Show resolved
Hide resolved
lilgreenbird
reviewed
Apr 5, 2019
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecuteWithErrorsTest.java
Show resolved
Hide resolved
rene-ye
approved these changes
Apr 8, 2019
peterbae
approved these changes
Apr 8, 2019
lilgreenbird
approved these changes
Apr 8, 2019
ulvii
reviewed
Apr 9, 2019
| String sql1 = "create table " + tableName + " (c1 float, c2 real)"; | ||
| stmt.execute(sql1); | ||
| } | ||
| } | ||
|
|
||
| @AfterAll | ||
| public static void terminateVariation() throws SQLException { | ||
| try (Connection connection = DriverManager.getConnection(connectionString); | ||
| Statement stmt = connection.createStatement()) { | ||
| try (Statement stmt = connection.createStatement()) { |
There was a problem hiding this comment.
Why are we changing the tests to use connection from AbstractTest? Dropping tables will fail if that connection is broken.
There was a problem hiding this comment.
This Static Connection is recreated everytime with every test class. This is an attempt to reduce number of connections specially when running tests with Azure databases.
There was a problem hiding this comment.
As also mentioned in PR description, this change reduces time of Junit execution by 45 secs in normal run (against SQL 2019) and much more on Azure databases.
ulvii
reviewed
Apr 9, 2019
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/SQLServerSpatialDatatypeTest.java
Show resolved
Hide resolved
ulvii
approved these changes
Apr 9, 2019
ulvii
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Tagging tests for exclusions safely excludes test classes/tests from being tested against targeted SQL Server. Exclusion tags are based on non-compatibility of tests against respective SQL Servers.
jacoco:mergeto generate cumulative code coverage for the source code.connectioninstance fromAbstractTestfor operations that do not require special connection like creating/dropping objects. Thisconnectionis created either way with every test. Reduces execution time by 45 secs.