Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change | Updated ISQLServerBulkData APIs to throw SQLException #1187

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

ulvii
Copy link
Contributor

@ulvii ulvii commented Nov 19, 2019

The PR also updates Bulk Copy tests to use ISQLServerBulkData instead of ISQLServerBulkRecord.

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #1187 into dev will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1187      +/-   ##
============================================
- Coverage     55.86%   55.74%   -0.12%     
+ Complexity     3551     3541      -10     
============================================
  Files           130      130              
  Lines         29332    29332              
  Branches       4855     4855              
============================================
- Hits          16385    16351      -34     
- Misses        10625    10657      +32     
- Partials       2322     2324       +2
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (-2.2%) 15% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 74.28% <0%> (-2.15%) 34% <0%> (-2%)
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 73.55% <0%> (-1.66%) 0% <0%> (ø)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 59.76% <0%> (-1.19%) 34% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.73% <0%> (-0.87%) 111% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java 43.72% <0%> (-0.81%) 26% <0%> (ø)
...ft/sqlserver/jdbc/SQLServerVSMEnclaveProvider.java 80.39% <0%> (-0.34%) 27% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 61.87% <0%> (-0.27%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (-0.22%) 43% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.88% <0%> (-0.18%) 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb3f12...b8dc83a. Read the comment docs.

@ulvii ulvii merged commit 3ebc3f9 into microsoft:dev Nov 22, 2019
@ulvii ulvii deleted the issue1185 branch November 22, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants