Fix | Close resources and skip AE tests by default #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulvii
reviewed
Apr 22, 2020
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCertificateUtils.java
Outdated
Show resolved
Hide resolved
peterbae
reviewed
Apr 22, 2020
...st/java/com/microsoft/sqlserver/jdbc/clientcertauth/ClientCertificateAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCertificateUtils.java
Outdated
Show resolved
Hide resolved
peterbae
reviewed
Apr 23, 2020
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCertificateUtils.java
Outdated
Show resolved
Hide resolved
peterbae
approved these changes
Apr 23, 2020
ulvii
approved these changes
Apr 23, 2020
lilgreenbird
approved these changes
Apr 24, 2020
lilgreenbird
previously requested changes
Apr 24, 2020
|
I'm not moving it to this PR, it doesn't matter which PR it goes in. |
rene-ye
dismissed
lilgreenbird’s stale review
not a valid reason to block the PR from going in
lilgreenbird
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Client Certificate Authentication tests to proper folder.
Explicitly close closable resources.
Skip AE tests by default so users don't require the AE folder to run tests.