Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted the IBM check to vendor check AND added an additional vm name check to remove false positives #2209

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Reverted the IBM check to vendor check AND added an additional vm name check to remove false positives #2209

merged 1 commit into from
Sep 6, 2023

Conversation

Jeffery-Wasty
Copy link
Contributor

@Jeffery-Wasty Jeffery-Wasty commented Aug 31, 2023 •
edited by lilgreenbird
Loading

The current isIBM check causes issues with OSGi environments. Instead, we're reverting to the previous check with vendor name, and adding an additional check with vm name to remove false positives, e.g. Semaru builds.

original issue #2139

@Jeffery-Wasty Jeffery-Wasty added this to the 12.4.2 milestone Aug 31, 2023
@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review August 31, 2023 21:41
@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.4.2, 12.5.0 Aug 31, 2023
@MrEasy
Copy link
Contributor

MrEasy commented Sep 5, 2023

easier than #2208 👍🏻

@MrEasy MrEasy mentioned this pull request Sep 5, 2023
Closed
@lilgreenbird lilgreenbird mentioned this pull request Sep 5, 2023
Closed
@Jeffery-Wasty Jeffery-Wasty linked an issue Sep 5, 2023 that may be closed by this pull request
12.4.1 fails to deploy in OSGi environment without com.ibm.lang.management #2207
Closed
@lilgreenbird lilgreenbird linked an issue Sep 6, 2023 that may be closed by this pull request
java.vendor name changed in openj9 #2139
Closed
@Jeffery-Wasty Jeffery-Wasty mentioned this pull request Sep 6, 2023
Merged
@Jeffery-Wasty Jeffery-Wasty merged commit 352cec3 into main Sep 6, 2023
17 checks passed
@Jeffery-Wasty Jeffery-Wasty deleted the IBMCheckRevertAndChange branch September 6, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@David-Engel David-Engel David-Engel approved these changes

@tkyc tkyc tkyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
Status: Closed/Merged PRs
Milestone
12.5.0
5 participants
@Jeffery-Wasty @MrEasy @lilgreenbird @David-Engel @tkyc