Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBSA update: TFA and RngLib #626

Merged
merged 3 commits into from
Jul 6, 2023
Merged

SBSA update: TFA and RngLib #626

merged 3 commits into from
Jul 6, 2023

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Jul 5, 2023

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

Current SBSA is using timer based RngLib, which is not appropriate as an example. This change updated the library to be instruction based.

Note that this instruction may not be available on all instructions sets.

The change also updates to the latest TFA release for our own housekeeping.

Fixes #616.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Booted SBSA platform firmware to Windows desktop.

Integration Instructions

N/A

@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact impact:security Has a security impact labels Jul 5, 2023
@kuqin12 kuqin12 requested review from os-d and cfernald July 5, 2023 23:03
@kuqin12 kuqin12 merged commit f1a3463 into microsoft:main Jul 6, 2023
@kuqin12 kuqin12 deleted the sbsa_rng branch July 6, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:security Has a security impact language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SBSA using timer based RngLib
3 participants