SecurityPkg: Temporarily remove DeviceSecurity (and libspdm) from build #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:breaking-change
Javagedes
approved these changes
May 22, 2024
apop5
approved these changes
May 22, 2024
os-d
approved these changes
May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #272 +/- ##
==============================================
Coverage 1.35% 1.35%
==============================================
Files 162 162
Lines 38591 38591
Branches 265 265
==============================================
Hits 521 521
Misses 38070 38070
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kuqin12
approved these changes
May 22, 2024
5 tasks
|
Waiting on tianocore/edk2-pytool-extensions#814 to pass CI. |
The SecurityPkg/DeviceSecurity/SpdmLib/libspdm submodule contains a unit_test/cmockalib/cmocka submodule to https://git.cryptomilk.org/projects/cmocka.git. cryptomilk.org is very unreliable and breaking all builds right now. Since the DeviceSecurity content is not actively used in any main branches, this change removes the libspdm submodule from the package which, in turn, leads to removal of the content dependent on the submodule. These changes are made such that this commit can be reverted in the future to easily restore everything after the libspdm submodule can find a more reliable host than cryptomilk.org. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
tianocore/edk2-pytool-extensions@v0.27.4...v0.27.5 Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
temp_remove_spdm_from_build
branch
from
dad5673
to
0e2b04c
Compare
antklein
approved these changes
May 22, 2024
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
SecurityPkg/DeviceSecurity/SpdmLib/libspdmsubmodule contains aunit_test/cmockalib/cmockasubmodule to https://git.cryptomilk.org/projects/cmocka.git.cryptomilk.org is very unreliable and breaking all builds right now.
Since the DeviceSecurity content is not actively used in any main
branches, this change removes the
libspdmsubmodule from the packagewhich, in turn, leads to removal of the content dependent on the
submodule.
These changes are made such that this commit can be reverted in the future.
That will easily restore everything after the
libspdmsubmodule is updatedto find a more reliable host than cryptomilk.org.
How This Was Tested
Integration Instructions
libspdmsubmodule in SecurityPkg, it isrecommended to stay on the commit prior to its removal and wait
for it to be restored in a future commit.
libspdmsubmodule, there is not impact.dependent on the
libspdmsubmodule will fail.