Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Add cmake-js dependency to package.json #246

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

danieljhegeman
Copy link
Contributor

Hi Napajs team,

I was installing Napajs from master and it failed as a result of a missing dependency, cmake-js. I've added it to the package.json, although I just put the most recent version; what would be the most appropriate minimum version requirement?

-Daniel

@fs-eire
Copy link
Contributor

fs-eire commented Jun 11, 2018

Thanks @danieljhegeman for this PR!

The npm package cmake-js was not considered as runtime dependency because when using the pre-built binaries, it is not necessary. It is necessary when there are no pre-built version of the current platform (which kicks a build), or build from napa.js source manually. So from this point of view, we consider it as a part of build prerequisites instead of package dependency.

Thus, I think it would be reasonable to put cmake-js in the dev-dependencies list.

@danieljhegeman
Copy link
Contributor Author

Thanks @fs-eire; whoops, I was moving too fast. Revised.

@fs-eire fs-eire merged commit f337e2c into microsoft:master Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants