This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix local system as remote machine issue #1852 #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull code
pull code
pull code
pull code
Fix gp tuner (microsoft#1592)
pull code
pull code
pull code
pull code
Fix compressor op_types (microsoft#1670)
pull code
pull code
pull code
pull code
pull code
pull code
Filter prune algo implementation (microsoft#1655)
pull code
pull code
pull code
pull code
pull code
pull code
pull code
pull code
pull code
pull code
pull code
chicm-ms
requested review from
SparkSnail,
20shivangi,
QuanluZhang and
liuzhe-lz
and removed request for
20shivangi
44 tasks
QuanluZhang
reviewed
Dec 17, 2019
QuanluZhang
approved these changes
Dec 18, 2019
SparkSnail
approved these changes
Dec 18, 2019
leckie-chn
reviewed
Dec 18, 2019
| const tmpTarName: string = `${uniqueString(10)}.tar.gz`; | ||
| const localTarPath: string = path.join(os.tmpdir(), tmpTarName); | ||
| const remoteTarPath: string = unixPathJoin(getRemoteTmpDir(remoteOS), tmpTarName); | ||
| const localTarPath: string = path.join(os.tmpdir(), `L${uniqueString(10)}.tar.gz`); |
There was a problem hiding this comment.
let's add a more meaningful name for tmpTarName (from @yds05 )
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.